Tidy test-drift-instability #2240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This case dominates the runtime of the test and perhaps (?) doesn't offer much more coverage
The runtest and runtest.py separation was briefly used to pass different command line arguments, but this is no longer necessary
Closed
dschwoerer
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zeff=2case fromtest-drift-instability(and the staggered version), which accounts for vast majority of the runtimeruntest.pyback to plainruntest-- this was separated out in order to pass an argument toruntest.py, but this was fixed to be no longer necessary some time ago, so there's no need for the separation now