Laplace3d bugfix backport #2242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are occasionally needed, and it only adds initialisation cost to calculate them.
The method actually creates the intersection. Fixes #2236.
getUnion() was misleadingly named, and actually gave the intersection. Region::operator+=(Region) updates a Region to be the union of two Regions, which is almost what was wanted, although we have to call mask_region.unique() afterwards too to ensure there are no repeated entries and the entries are sorted.
Suggested by clang-tidy.
Stencil was storing a lambda which captured some state by reference, which went out of scope before the lambda was called. Fix is to capture by value. `RangeIterator` is not particularly expensive to copy, so this should not affect performance. Possible issue with linked `RangeIterator`s?
Fix copied from fix to PETSc interface in dd8bed9: Stencil was storing a lambda which captured some state by reference, which went out of scope before the lambda was called. Fix is to capture by value. `RangeIterator` is not particularly expensive to copy, so this should not affect performance. Possible issue with linked `RangeIterator`s?
Like recent fix to test-laplace-petsc3d, paralleltransform option was in wrong section.
Previously operator+=() called setValues(), which overwrites any existing value in the matrix element. It should add to existing values, so now calls new addValues() method, which in turn calls new HypreMatrix::addVal() method.
ZedThree
approved these changes
Feb 24, 2021
examples/laplacexy/simple doesn't compile under Cuda. In the very short term just to test this PR it is commented out in Top level CMakeLists.txt. This app needs changes to its CMakeLists.txt or should not be compiled under Cuda - both are very easy fixes. It will be remedied in next update to next-hypre-outerloop-cuda
|
elmpb is still unstable while running against laplacexy-hypre. While I do have a few stability fixes in the works, we absolutely need to work on initialization and assembly checks. But, this PR looks good with the couple of inline edits I added earlier. |
johnomotani
deleted the
next-hypre-outerloop-cuda-laplace3d-bugfix-backport
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #2237, and extends the bugfix to
LaplaceHypre3d.Also includes a fix for
operator+=()in the Hypre interface, which was previously over-writing values instead of adding to them.