Set extra boundary cells in LaplaceXY2 and LaplaceXY2Hypre #2246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to include bout/build_defines.hxx.
Set boundary points past the first one in very dumb way, just set equal to the first boundary point. Should avoid use of uninitialised values though.
Set boundary points past the first one in very dumb way, just set equal to the first boundary point. Should avoid use of uninitialised values though.
johnomotani
commented
Mar 1, 2021
Comment on lines
+36
to
+38
| #include <bout/build_defines.hxx> | ||
|
|
||
| #if not BOUT_HAS_HYPRE |
There was a problem hiding this comment.
@ZedThree is this the correct way to be using BOUT_HAS_HYPRE? Should we prefer bout::build::has_hypre from bout/build_config.hxx instead?
There was a problem hiding this comment.
This is correct 👍
bout::build::has_hypre is a standard variable so is useful in "ordinary" code, but if used in e.g. an if statement, both branches have to compile in all cases.
johnomotani
deleted the
next-hypre-outerloop-cuda-set-laplacexy2-boundary-cells
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might fix some uses of uninitialised values.
@jonesholger does this fix the NaN exception you had?
This PR includes some fixes for the use of
BOUT_HAS_HYPREinlaplacexy2_hypre.cxx, which I needed to get the autotools build to work. I think the new versions are the 'correct' style. Probably needs checking that this is correct with the CMake build too.