Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes and test for LaplaceXY2Hypre; runtime options for Hypre interface #2247

Merged
merged 14 commits into from
Mar 9, 2021
Merged

Fixes and test for LaplaceXY2Hypre; runtime options for Hypre interface #2247

merged 14 commits into from
Mar 9, 2021

Conversation

johnomotani
Copy link
Contributor

  • Integrated test for LaplaceXY2Hypre
  • Fixes for bugs found with integrated test
  • Add an Options &options argument to the HypreSystem constructor, use it to allow options to be set at run-time
  • Simplify options handling in LaplaceHypre3d, removing things now handled by HypreSystem
  • Setting to control command-line output from LaplaceXY2Hypre (off by default)

@johnomotani
Remove unused members of LaplaceHypre3d
2c2f12f 
Were originally copied from LaplacePetsc3dAmg.
@johnomotani
Standardise output statements in laplacexy2_hypre.cxx
059fb89 
Use BOUT++ 'output' rather than std::cout.
@johnomotani
Pass run-time options to HypreSystem
2716f20 
Add an "Options& options" argument to the HypreSystem constructor so
that it can get run-time options. Use the options to set solver_type,
rtol, atol, maxits, and print_level.
@johnomotani
Make stdout output optional in LaplaceXY2Hypre
590b368
@johnomotani
Set boundary values in LaplaceXY2Hypre
0d3e849
@johnomotani
Add hyprelib.cxx to makefile
493977d 
Needed for autotools builds.
@johnomotani
Fix SquareStencil in LaplaceXY2Hypre for Field2D
b5c7de4 
Should include neighbouring points in y, not in z.
@johnomotani
Fix setting of invalid matrix elements in boundaries in LaplaceXY2Hypre
d29d149 
Need to use the boundary regions defined by indexConverter.
@johnomotani
Integrated test for LaplaceXY2Hypre
327c2d9
@johnomotani
Copy link
Contributor Author

By the way, I think LaplaceXY2 is broken (not LaplaceXY, which should be fine).

I don't think the intention was ever for LaplaceXY2 to be a long-term option, so not sure what the best thing to do is. I guess either copy the test in this PR for LaplaceXY, and fix any bugs (fixes can probably be copied from LaplaceXY2Hypre), or remove it. If we remove it, I'd be nice to convert LaplaceXY to use the PETSc interface, but that's probably a job for later (maybe after merging the PETSc and Hypre interfaces into a common structure).

@johnomotani
Use zero for initial guess in LaplaceHypre3d test
38511ef 
Previously was using expected solution as initial guess, this is
probably not a great test...
@johnomotani
Set hypre_print_level for Hypre solver as well as BoomerAMG precon
7bbdb64 
Print out extra info when we raise the hypre_print_level.
@johnomotani
Fix use of BOUT_HAS_PETSC in LaplaceXY2
3bc849c
@ZedThree
Copy link
Member

ZedThree commented Mar 5, 2021

I really like the BOUT_ENUM_CLASS and its ability to set an enum from Options -- such a nice feature! Thanks @johnomotani!

@jonesholger jonesholger merged commit 797ec85 into next-hypre-outerloop-cuda Mar 9, 2021
@johnomotani johnomotani deleted the next-hypre-outerloop-cuda-runtime-options branch March 9, 2021 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZedThree ZedThree ZedThree left review comments

@jonesholger jonesholger Awaiting requested review from jonesholger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@johnomotani @ZedThree @jonesholger