Restrict region for toFieldAligned() in VDDY() when not staggered #2268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the derivative is not staggered, vel_aligned does not require y-guard cells, so toFieldAligned() can use "RGN_NOBNDRY" instead of "RGN_NOX". This is a slight optimisation, and avoids an exception that can be thrown from b0xGrad_dot_Grad() when using ShiftedMetricInterp, which is thrown because a result is calculated in uninitialised guard cells where it is not needed.
johnomotani
added
bugfix
small-change
|
clang-tidy review says "All clean, LGTM! 👍" |
ZedThree
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the derivative is not staggered,
vel_aligneddoes not require y-guard cells, sotoFieldAligned()can use"RGN_NOBNDRY"instead of"RGN_NOX". This is a slight optimisation, and avoids an exception that can be thrown fromb0xGrad_dot_Grad()when usingShiftedMetricInterp, which is thrown because a result is calculated in uninitialised guard cells where it is not needed.