Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set all boundary cells in LaplaceXZ #2281

Merged
merged 2 commits into from
Apr 13, 2021
Merged

Set all boundary cells in LaplaceXZ #2281

merged 2 commits into from
Apr 13, 2021

Conversation

bshanahan
Copy link
Contributor

  • Also fixes a small typo in examples

* Also fixes a small typo in examples
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/invert/laplacexz/impls/petsc/laplacexz-petsc.cxx Outdated Show resolved Hide resolved
src/invert/laplacexz/impls/petsc/laplacexz-petsc.cxx Outdated Show resolved Hide resolved
johnomotani
johnomotani previously approved these changes Apr 13, 2021
Copy link
Contributor

@johnomotani johnomotani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - I do agree with clang-tidy though :-)

@ZedThree
Copy link
Member

Thanks @bshanahan ! Does this fix the problems in #2207 do you know?

@bshanahan
Copy link
Contributor Author

Thanks @bshanahan ! Does this fix the problems in #2207 do you know?

I don't think so :(.

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@ZedThree ZedThree merged commit b9d3aff into next Apr 13, 2021
@ZedThree ZedThree deleted the laplacexz-bndry-fix branch April 13, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants