Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faster recompile #2294

Merged
merged 6 commits into from
May 4, 2021
Merged

Faster recompile #2294

merged 6 commits into from
May 4, 2021

Conversation

dschwoerer
Copy link
Contributor

Especially nice if working with shared libraries, and only a single, small file needs to be recompiled.

Recompiling bout++.cxx can take a long time, and this issue issue is avoided this way.

Due to #1933 not useful for cmake ...

I accidentally included 73e7ad8 - but that might be useful anyway to avoid a regression?

dschwoerer and others added 4 commits April 10, 2020 18:39
@dschwoerer
check we are never adding a var twice
73e7ad8
@dschwoerer
Merge branch 'next' of github.com:boutproject/BOUT-dev into never-add…
f42b15e 
…-twice
@dschwoerer
Faster recompile
ea78d91 
By splitting the __TIME__ and __DATE__ to a different header, it makes
it much faster to compile.

This is especially beneficial in a edit-compile-debug cycle.
@dschwoerer
Fix compilation
614c519 
* CMake needed new file
* avoid race condition in autotools
@dschwoerer dschwoerer added the build-system issues with make/configure/... label Apr 28, 2021
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

ZedThree
ZedThree requested changes Apr 30, 2021
View reviewed changes
Copy link
Member

@ZedThree ZedThree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @dschwoerer ! One small change please :)

src/bout++.cxx Outdated Show resolved Hide resolved
@ZedThree
Copy link
Member

The black test is failing because it's trying to run on everything and two files are not compatible with python 3.

@dschwoerer @ZedThree
fix order of date and time
d2750d5 
Co-authored-by: Peter Hill <zed.three@gmail.com>
@dschwoerer
Copy link
Contributor Author

The black test is failing because it's trying to run on everything and two files are not compatible with python 3.

I am confused why it is trying to do that now. Shouldn't black already be running on next?
I further thought that this has already succeded, where the files reintroduced accidentially?

@ZedThree
Copy link
Member

ZedThree commented May 4, 2021

black is failing on this file: https://github.com/boutproject/BOUT-dev/blob/d2750d5cd3fa7b17b75ffbc9001c9163839a2967/tools/tokamak_grids/pyGridGen/aeqdsk.py

which no longer exists in next. I think this is just because this branch was off an old version of next. I suggest merging in latest next

@dschwoerer
Copy link
Contributor Author

It seems I forgot to fetch before merging next. Thanks for the catch, it now works 👍

@ZedThree ZedThree merged commit f623cb8 into next May 4, 2021
@ZedThree ZedThree deleted the faster-recompile branch May 4, 2021 16:16
@ZedThree ZedThree mentioned this pull request Jul 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZedThree ZedThree ZedThree approved these changes

Assignees
No one assigned
Labels
build-system issues with make/configure/...
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dschwoerer @ZedThree