cyclic reduction solver documentation #2296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doesn't actually implement cyclic reduction, but a two-level partitioning algorithm.
|
👍 for renaming (in next). |
|
Agreed with renaming in next (and adding to the documentation). Is there any value in a actual cyclic reduction implementation? |
|
👍 for renaming in next. We've now also got a way of "registering" disabled implementations, so we can use that to point users to the new name |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Confusingly, the
CyclicReducetridiagonal solver, used in thecyclicpotential and parallel inversion solvers, doesn't implement cyclic reduction. Instead it implements a two-level partitioning algorithm which is described in this LANL report from 2004: https://citeseerx.ist.psu.edu/viewdoc/download?doi=10.1.1.104.9454&rep=rep1&type=pdfShould the solver and file be renamed?