CMake: Build Python API #2298
Merged
CMake: Build Python API #2298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The files are part of $(TOGEN)
If requested, but requirements are not present, this will fail, rather then ignore the requested option
Default is to enable, if requirements are present.
|
Awesome, thanks @dschwoerer ! Overall it looks good. To make it a bit cleaner, I'd probably move the numpy stuff into I'm not sure about forcing shared libs on. It might be nicer to instead have an overall default of shared libs and then a check and fatal error if they're not enabled. |
ZedThree
reviewed
May 17, 2021
* next: (349 commits) Delete integrated test of FieldFactory: replaced by unit tests Convert ersatz MMS tests to use library MMS features Disable tests by default if building as part of another project CMake rename PACKAGE_TESTS to BOUT_TESTS Add some docs for formatting `Options` to string Fix for conditionally used boundary condition inputs in 'all' Further improve test-invpar fix WithQuietOutput speedup test-invpar Update .gitignore Enable running tests in parallel Add test for invalid Options format string Fix more clang-tidy suggestions Fix clang-tidy suggestions Replace OptionINI::writeSection with fmt::format Print docstring and type info for unused inputs Fix `Options` formatting to handle values correctly Add more format specs for `Options`: key-only and source attribute Add `fmt::formatter` for `Options` Restrict Options implicit cast operator to only types in variant ...
ZedThree
previously approved these changes
Jun 11, 2021
|
@dschwoerer I've made some changes, are you ok with them? |
Now stops immediately if option was `MAYBE`, and FATAL_ERROR if option was turned on
|
Yes, looks good. Sorry I didn't get around to it myself. Much appreciated 👍 |
ZedThree
approved these changes
Jun 11, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add cmake instructions for boutcore
Resolves #1940
Resolves #2289
I need to remove the commented out code, but maybe @ZedThree also has some further ideas to cleanup.
I am not sure about auto-enabling. The issue is that in order to build a .so,
-fPICis needed, which seems to be only inserted withBUILD_SHARED_LIBS=ON.I also just noticed I need to move this a bit further down, so it is only enabled when we are building the interface.
BOUT-dev/CMakeLists.txt
Line 428 in 1dd83c6