Update installation suggestions for Marconi/gnu #2299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New library versions, and recently checked instructions.
johnomotani
added
documentation
small-change
ZedThree
approved these changes
May 4, 2021
dschwoerer
reviewed
May 4, 2021
| mkdir build | ||
| cd build | ||
| cmake -DCMAKE_INSTALL_PREFIX=/directory/to/install/netcdf -DCMAKE_BUILD_TYPE=Release .. | ||
| CPPFLAGS="-I<prefix for hdf5>/include -I<prefix for netcdf>/include" LDFLAGS="-L<prefix for hdf5>/lib/ -L<prefix for netcdf>/lib/" ./configure --prefix=<prefix for netcdf> |
There was a problem hiding this comment.
rather then repetetive <prefix ...> it would be nice to set NETCDFDIR=<prefix ...> and then use $NETCDFDIR
| @@ -213,37 +213,33 @@ The following configuration commands have been used successfully: | |||
| make | |||
| make install | |||
|
|
|||
| * netCDF-4.7.4:: | |||
| * netCDF-4.7.4 (note: using cmake to build gave errors in ``make test`` while the autotools build with ``configure`` passed all tests in ``make check``; netCDF-4.8.0 failed to link to hdf5-1.12.0 and failed tests with both cmake and autotools):: | |||
There was a problem hiding this comment.
I think it is nicer to put the notes below the commands, without () - but this is just personal taste.
There was a problem hiding this comment.
both good points, but it's merged now...
There was a problem hiding this comment.
Sorry, I was a bit quick off the mark there!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New library versions, and recently checked instructions.