-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instructions for MPCDF clusters #2305
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could put the bash script in something like bin/bout-build-on-draco.sh
?
We might be able to incorporate a fair bit of this into the CMake build. We already have an option for downloading and building the netCDF C++ API for instance.
[skip ci]
[skip ci]
@johnomotani I updated the marconi GNU instructions - I am happy to revert if you prefer your version ... |
Looks good to me, but it'd be nice to add a bit of documentation of |
As most of the current users of Draco are using FCI, it's probably best to add openmp to the available libraries. |
readthedocs is failing because we need #2308 first |
A short docstring in |
An alternative to this is to use spack. There's some spack files already in the GPU branches, e.g. https://github.com/boutproject/BOUT-dev/blob/next-hypre-outerloop-cuda/scripts-config/lassen-examples/spack_env/bout/spack.yaml It looks like it might also not be very much effort to create a spack package for BOUT++ itself, which might make it even easier to install all the dependencies. Using spack would require users to learn another tool, but might mean less maintenance for BOUT++ developers. |
* Generate environment modules makes it easier to load the dependencies in HPC environments. It also allows to manage different dependency sets. * Improve summary * Add comments to commands in the end to make editing easier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well for me.
I haven't tested the openmp flags well, they seem to configure without issues, but I have not checked that it actually uses threads ... |
Otherwise also scripts are found that generate other files
For the future, it might be easier to integrate downloading + compiling of dependencies within cmake ...? |
For intel based tools: |
Yes, there's a few options for this: Conan, vcpkg, CPM. Or we can have a "superproject" that includes BOUT++ and downloads and compiles all the dependencies. This looks ok to me. We could move the script into https://github.com/boutproject/BOUT-configs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Would it be possible to use bout-build-deps.sh in one of the github tests, so we can make sure that it is updated when needed?
Let's move this to the BOUT-config repo and remove the machine specific instructions entirely |
The instructions are based on the marconi ones.
Would it make sense to put them rather in a bash file (where?) and reference that instead?