Add Mesh method to get all possible boundary regions #2307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnomotani
approved these changes
May 7, 2021
| // each possible boundary. We only need to do this at PE_XIND==0, as | ||
| // the other X boundary is covered by the case above | ||
| for (const auto& y_index : | ||
| {0, jyseps1_1, jyseps1_2, ny_inner - 1, ny_inner, jyseps2_1, jyseps2_2, ny - 1}) { |
There was a problem hiding this comment.
Is it necessary to do jyseps* here? I think the targets (where we actually apply y-boundary conditions) are only at 0, ny-1, and (if jyseps2_1==jyseps1_2) ny_inner-1 and ny_inner.
There was a problem hiding this comment.
It's definitely possible there's a smaller set we can check, but we also need to check for any inner x-boundary, so I think we do need to check at least one jyseps.
There was a problem hiding this comment.
ah, right. makes sense!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a method to return a set of all possible boundary region names in a given configuration.
Merging into #2245 to reduce diff
Needed for #2210