CMake: Add separate configure-time option for MsgStack

[dschwoerer]

Formatting took over 50% of the run time, so I added an option to disable it while keeping the full checks enabled.

This is really useful if you want to debug on a small mesh, as you get the stack trace anyway with e.g. gdb.

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"

[ZedThree]

Might make sense to make it just on/off, with a default value of CHECK > 1? If so, the name should be BOUT_USE_MSGSTACK

Please could you also add it to include/bout/build_config.hxx, and write it out in src/bout++.cxx, in printCompileTimeOptions, setupDumpFile?

The other option would be to just bump up the CHECK level that it gets enabled at.

[dschwoerer]

Might make sense to make it just on/off, with a default value of CHECK > 1? If so, the name should be BOUT_USE_MSGSTACK

I don't mind, will change 👍

Please could you also add it to include/bout/build_config.hxx, and write it out in src/bout++.cxx, in printCompileTimeOptions, setupDumpFile?

Sure 👍

The other option would be to just bump up the CHECK level that it gets enabled at.

Even at level 4 I wouldn't want them, as they add no value if I already have compiled with -g.
Without -g and/or without the native stacktrace the msgstack would add value, but I prefer -g as that gives much more info at smaller cost.

[dschwoerer]

I cannot find anything in the docs on this, is it possible to evaluate a statement without if?

I want to assign the result of the comparison CHECK > 1 - is there another way to:

if (CHECK GREATER 1)
  set(VALUE ON)
else ()
  set(VALUE OFF)
endif()

[ZedThree]

Yeah, I think that's the cleanest way. Everything is stringly-typed in CMake, so boolean expressions basically only work inside if

[ZedThree]

LGTM, pick one of the suggestions depending on how you want to use this :)

[github-actions]

clang-tidy made some suggestions