Fix make -q #2322
Merged
Fix make -q #2322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using real, empty targets make -q always returned false. Using order only dependencies only is the proper solution and fixes this issue
|
Looks like there is something wrong with GHA 😞 |
|
Yeah, GHA having problems: https://www.githubstatus.com |
ZedThree
approved these changes
May 18, 2021
|
Lovely, good stuff @dschwoerer ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using real, empty targets
make -qalways returned false. Using orderonly dependencies is the proper solution and fixes this issue