Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not include inner corner cells in FCI #2323

Merged
merged 1 commit into from
May 19, 2021
Merged

Do not include inner corner cells in FCI #2323

merged 1 commit into from
May 19, 2021

Conversation

dschwoerer
Copy link
Contributor

The inner corner values (i.e. values in the parallel slices, that are in the inner x-boundary) are normally not set, and should thus not be used.

I think this can also go to next, and then be merged into the 3D branch.

@dschwoerer dschwoerer requested a review from bshanahan May 18, 2021 13:02
Comment on lines +135 to +137
} else {
xt_prime_corner[i] =
0.25 * (xt_prime[i] + xt_prime[i_xplus] + xt_prime[i_zplus] + xt_prime[i_xzplus]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I see any difference, this change is functionally identical? Am I missing something?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, yes, that is just a cleanup - I thought the continue was confusing, if the else branch is so short.

Probably should have gone into another commit ...

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@ZedThree
Copy link
Member

Fedora failing test is a Timer unit test:

The difference between Timer::getTime("ResetTimeLabelInScope test") and elapsed.count() is 0.0005812180000000001, which exceeds bout::testing::TimerTolerance, where
Timer::getTime("ResetTimeLabelInScope test") evaluates to 0.0016420510000000001,
elapsed.count() evaluates to 0.001060833, and
bout::testing::TimerTolerance evaluates to 0.00050000000000000001.

This is probably fine and just one of the difficulties of unit testing timers

@ZedThree ZedThree changed the title Do not include inner corner cells Do not include inner corner cells in FCI May 19, 2021
@ZedThree ZedThree merged commit 656e11f into next May 19, 2021
@ZedThree ZedThree deleted the 3d-no-corners branch May 19, 2021 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants