Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: Add option to download SUNDIALS at configure time #2331

Merged
merged 3 commits into from
May 24, 2021

Conversation

ZedThree
Copy link
Member

Similarly to the netCDF C++ API, -DBOUT_DOWNLOAD_SUNDIALS=ON will download and build SUNDIALS as part of the BOUT++ build. This should make it much easier to use SUNDIALS on systems that don't have it installed.

Currently needs my (Peter's) fork because the latest release is
missing an export() call that allows it to work with
FetchContent.

Also a small change to FindSundials to make the
download/non-download options work in the same way

Currently needs my (Peter's) fork because the latest release is
missing an `export()` call that allows it to work with
`FetchContent`.

Also a small change to `FindSundials` to make the
download/non-download options work in the same way
@ZedThree ZedThree added the build-system issues with make/configure/... label May 21, 2021
@ZedThree ZedThree added this to the BOUT-5.0 milestone May 21, 2021
bendudson
bendudson previously approved these changes May 24, 2021
Copy link
Contributor

@bendudson bendudson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works on YPI server (Avalanche). I've made a PR into this branch with a bit of documentation.

bendudson and others added 2 commits May 24, 2021 10:06
Mention that CMake can be used to download NetCDF and SUNDIALS
dependencies.
Add downloading dependencies to CMake install doc
@bendudson bendudson merged commit 19b4330 into next May 24, 2021
@bendudson bendudson deleted the cmake-download-sundials branch May 24, 2021 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-system issues with make/configure/...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants