Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: Add integration test for bout-config #2334

Merged
merged 2 commits into from
May 27, 2021
Merged

CMake: Add integration test for bout-config #2334

merged 2 commits into from
May 27, 2021

Conversation

dschwoerer
Copy link
Contributor

No description provided.

@ZedThree
Copy link
Member

ZedThree commented May 27, 2021 •
edited

Thanks @dschwoerer !

Might be an idea to have set -ex in the script? EDIT: I'll do this in the base PR

@ZedThree ZedThree merged commit 16157fd into cmake-test-conflicts May 27, 2021
@ZedThree ZedThree deleted the cmake-test-conflicts-test branch May 27, 2021 08:16
@dschwoerer
Copy link
Contributor Author

Ah, I had set that in the debug commits, that I have removed during rebase 😅

Otherwise it will only fail if the last command fails, and ignores the test results completely ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZedThree ZedThree ZedThree approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dschwoerer @ZedThree