Add fmt::formatter for Options
#2341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that bool = options["foo"]; will still work, while dcomplex = options["foo"]; will need to be changed to: dcomplex = options["foo"].as<dcomplex>(); This is needed so that we can pass `Options` to templated functions and avoid ambiguous conversions, etc.
Previously `fmt::format("{}", options["value"])` was not handled
correctly, as the formatting implicitly assumed the `Options` was a
section
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
clang-tidy review says "All clean, LGTM! 👍" |
bendudson
approved these changes
Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optionscan now be converted to a string withfmt::formatwith the following format options:(happy to bikeshed these, but this vague set is useful)
This allows us to replace both
toString(Options)andOptionINI::writewith calls tofmt::formatinstead.The unused inputs error can now print out the type and docstring, e.g.:
which uses
fmt::format("\t{:idk}\n", suggestion)for each suggested alternative.This will also be helpful for #2336, being able to print the docstring