speedup test-invpar #2344
Merged
speedup test-invpar #2344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On a HPC system the precious code took ~10 minutes, now it takes ~15 seconds. It moves the loops to C++, thus avoiding most of the expensive initialisation of BOUT++.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ZedThree
requested changes
Jun 4, 2021
There was a problem hiding this comment.
Really nice, thanks @dschwoerer ! Similar speedup on my machine, down from 7 minutes to 15 seconds 🎉
The output of the test is now like:
1 processors....
flags ' acoef_0=1 bcoef_0=0 ccoef_0=0 dcoef_0=0 ecoef_0=0 acoef_1=1.5 bcoef_1='2.*sin(2*y)' acoef_2=1 acoef_3=1 bcoef_3=2 acoef_4=1 ccoef_4=1.793 acoef_5=1 ccoef_5=3 bcoef_5=0 acoef_6=1 dcoef_6=3.5 acoef_7=1 ecoef_7=-1 acoef_8=1 input_field_8='ballooning(exp(-y*y)*cos(z)*gauss(x,0.2))'' ... PASSED
flags ' acoef_0=1 bcoef_0=0 ccoef_0=0 dcoef_0=0 ecoef_0=0 acoef_1=1.5 bcoef_1='2.*sin(2*y)' acoef_2=1 acoef_3=1 bcoef_3=2 acoef_4=1 ccoef_4=1.793 acoef_5=1 ccoef_5=3 bcoef_5=0 acoef_6=1 dcoef_6=3.5 acoef_7=1 ecoef_7=-1 acoef_8=1 input_field_8='ballooning(exp(-y*y)*cos(z)*gauss(x,0.2))' mesh:ixseps1=0 mesh:ixseps2=0' ... PASSED
Might be nice to move the output of the flags from the python script to the C++ file too?
WithQuietOutput unconditionally enabeled the output again. To enable the output properly again, it needs to know the actual state and stores that.
Thanks @ZedThree for the suggestions. Now the test results are printed from the C++ code.
|
I bet there's a fair few other tests where we loop over things in python, when we could be doing that in the C++ file. There's also lots of tests where we save fields to disk and then read them in only to do |
ZedThree
approved these changes
Jun 4, 2021
|
This shaves 5-10 minutes off each CI job, so we save ~1 hour of cpu-time for each PR 🎉 A really awesome PR, thanks again @dschwoerer ! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a HPC system the precious code took ~10 minutes, now it takes ~15
seconds.
It moves the loops to C++, thus avoiding most of the expensive
initialisation of BOUT++.
Resolves #2185