Fixing up 6field-simple example in next #2346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- zonal_{flow, field, bkgd} are booleans, but set to -1 in the input
- low_pass_z is an integer, but read as a bool
Moving comments into doc strings, so they are written to the BOUT.settings file, and available for other outputs.
Makes intent clearer, and number of arguments is no longer needed due to macro magic.
Tidying comments e.g. author already in git commit / git blame.
Caught by new unused options checker.
BOUT++ is now quite strict in ensuring correctness of calculations involving staggered variables. For now just leave everything as cell centre.
Was passing a subsection of `[highbeta]`, but input expected a separate top-level section. Hence input options to `phiSolver` and `aparSolver` were not being used. Another win for strict input checking!
|
clang-tidy review says "All clean, LGTM! 👍" |
Previously the `phiSolver` and `aparSolver` inputs weren't being used, so defaulted to Dirichlet boundaries. When using the options, failed with zero pivot. The cause was setting zero-gradient on both boundaries for the DC component. Now changed to Dirichlet (inner) and Neumann (outer).
Removing variables which are not used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now runs for at least a couple of outputs, but I don't know if it's correct (I doubt it is).
Probably ok to merge now. Tests will hopefully be added later