CMake rename PACKAGE_TESTS to BOUT_TESTS #2347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bendudson
added
build-system
If including BOUT++ as a dependency, this namespacing makes it easier to select which tests should be run: In some cases (e.g. CI, Github actions) only the tests for the physics model should be run, and not the BOUT++ tests.
|
It might also be useful to set the default value like this: # Are we building BOUT++ directly, or as part of another project
string(COMPARE EQUAL
"${PROJECT_NAME}" "${CMAKE_PROJECT_NAME}"
PROJECT_IS_TOP_LEVEL
)
option(BOUT_TESTS "Build the tests" ${PROJECT_IS_TOP_LEVEL}) |
ZedThree
previously approved these changes
Jun 10, 2021
ZedThree
approved these changes
Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If including BOUT++ as a dependency, this namespacing makes it easier to select which tests should be run: In some cases (e.g. CI, Github actions) only the tests for the physics model should be run, and not the BOUT++ tests.