CMake: Add SOVERSION; fix FindSUNDIALS #2358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously a failure to find SUNDIALS_nvecparallel_LIBRARY resulted in a compile time error. This makes this a configure error.
This ensures we do resolve to a well specified version. If there is a globally installed BOUT++ with .so, the local version is used, as long as the SOVERSION is different.
ZedThree
requested changes
Jul 1, 2021
strings ending in -NOTFOUND are False Co-authored-by: Peter Hill <zed.three@gmail.com>
ZedThree
approved these changes
Jul 5, 2021
ZedThree
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a soname (maybe should be the same as the autotool one)?
Fix sundials issue