Bug fixes for imex-bdf2 solver #2372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy-paste error, extracting data from wrong Vec Shouldn't have affected any results, since only affects preconditioner, but might have made preconditioners less effective than they could have been.
bendudson
added
bugfix
small-change
Vec is locked by PETSc (at least in 3.20), so need read-only access. Since `load_vars` takes a `BoutReal*`, a `const_cast` is needed for now.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| ierr = VecGetArray(x,&xdata);CHKERRQ(ierr); | ||
| load_derivs(xdata); | ||
| ierr = VecRestoreArray(x,&xdata);CHKERRQ(ierr); | ||
| const BoutReal *xdata; |
There was a problem hiding this comment.
warning: variable xdata is not initialized [cppcoreguidelines-init-variables]
const BoutReal *xdata;
^
= nullptr| ierr = VecRestoreArray(x,&xdata);CHKERRQ(ierr); | ||
| const BoutReal *xdata; | ||
| ierr = VecGetArrayRead(x,&xdata);CHKERRQ(ierr); | ||
| load_derivs(const_cast<BoutReal*>(xdata)); // Note: load_derivs does not modify data |
There was a problem hiding this comment.
warning: do not use const_cast [cppcoreguidelines-pro-type-const-cast]
load_derivs(const_cast<BoutReal*>(xdata)); // Note: load_derivs does not modify data
^
ZedThree
approved these changes
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with latest petsc release (3.15). In the preconditioner:
Both of these issues were caught by PETSc's increasing strictness with locking of vectors.