Configuration on Cori with nvcc #2413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing which configurations work on Cori
Not used anywhere, duplicates functionality in include/bout/build_config.hxx
Set of header files included in the source list, but not used anywhere
Two step process: First set the environment, then configure BOUT++.
If all sources are marked as CUDA files, then nvcc attempts to compile everything, including header files. One solution is to split the sources into header and cxx files. This uses list FILTER to do that automatically.
Previously hard-wired, now can be changed if needed
Copy and swap compiles fine with nvcc, with BOUT_HOST_DEVICE
|
clang-tidy review says "All clean, LGTM! 👍" |
|
Library compiling on Cori (with nvcc) but doesn't link. Error is Suspect NetCDF configuration issue. |
Used for debugging, but not necessary in outputs
nvcc seems to need a constructor, rather than inferring a constructor which gcc does
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to enable configuration and compilation on Cori.
Selectively merging some scripts from Holger's branch
Deleting a number of unneeded / unused files.