Set CMAKE_BUILD_TYPE default to RelWithDebInfo #2428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following suggestion of @d7919, using BuildType.cmake from GS2: https://bitbucket.org/gyrokinetics/utils/src/8.1-RC/cmake/BuildType.cmake As suggested by @ZedThree, using RelWithDebInfo as the default. This results in compiler flags "-O2 -g" (on my laptop).
|
@dschwoerer The Fedora builds have stopped working, it looks like the |
ZedThree
approved these changes
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default build type is Debug, which results in no optimisation flags. In simple examples (e.g blob2d) this runs nearly 100 times slower than when compiled with Release build type (see PR #2427). This change aims to improve the out-of-the-box performance.
Following suggestion of @d7919, using BuildType.cmake from GS2:
https://bitbucket.org/gyrokinetics/utils/src/8.1-RC/cmake/BuildType.cmake
As suggested by @ZedThree, using RelWithDebInfo as the default.
This results in compiler flags "-O2 -g" (on my laptop).