Fix hypre test #2431
Fix hypre test #2431
Conversation
…hen using nvcc; add defined __CUDACC__ to elmpb when compiling host only
|
Also hw3d BOUT.inp needs edits as BOUT will complain that some options are not correct. |
|
to avoid "system" provided netcdf consider the use of BOUT_NETCDF_VERSION (this works for me on Cori) if (BOUT_NETCDF_VERSION) with script changes (note netCDF_ROOT is still needed to fully qualify search, since we'll fall thru initial find_package) |
|
PETSc find uses small code to test viability of install but this generates several HDF5 link errors such as which I can specify as follows this gets picked up by check_c_source_runs |
|
Just a reminder to build serial tests use : cmake --build . -j --target serial_tests |
…_package; reverted FindPETSc to full version - change script to add RPATHS to CMAKE_C_FLAGS if you have trouble running mulitpass tests; keep a simple version of FindPETSc
|
clang-tidy review says "All clean, LGTM! 👍" |
Mainly whitespace, delete unused files
…t program unwind still needs to be fixed
…v into fix_hypre_test
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/mesh/coordinates_accessor.cxx
Outdated
| @@ -71,8 +72,8 @@ std::size_t CoordinatesAccessor::clear(const Coordinates* coords) { | |||
| std::size_t num_removed = coords_store.size(); | |||
| coords_store.clear(); | |||
| return num_removed; | |||
| } else { | |||
There was a problem hiding this comment.
warning: do not use else after return [readability-else-after-return]
} else {
^~~~~~…lt petsc in tpl_11p
Squash a Clang tidy warning
invert_laplace and invert_parderiv have declarations which are needed for GCC & Clang, but cause multiple-definition errors with NVCC.
Default argument is `nullptr`.
Keep this test for checks in Github actions
Need to override the cache, ensure that pthreads is disabled. Fixes segfault (on my laptop anyway)
The main purpose of the PR is to fix Hypre Vector Unit Test "Assemble" when linked against Hypre v2.22.0 (Cuda-Compiled)
Hypre v2.22.0 is needed while compiling with CUDA 11.1.1
CUDA 11.1.1 is needed because BOUT introduced recursive lambdas in Options processing.
change your tpl_prefix to tpl_11h to pick up this new version of Hypre
Built/Tested with RAJA off and Umpire off on lassen and Cori-GPU: we are really only exercising Hypre CUDA
Secondarily we have made some CMake changes:
Propagate Warning Flags to the Host Compiler through -Xcompiler when compiling with nvcc
See below for recommended script changes if you have trouble with either FindnetCDF or FindPETSc