Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace 'config' directory with submodule #2465

Merged
merged 2 commits into from
Dec 1, 2021

Conversation

ZedThree
Copy link
Member

As discussed in #2397, moves all the configuration scripts out into a standalone repo and replaces them with a submodule to that repo.

@johnomotani
Copy link
Contributor

Do we even want to include the configs as a subdirectory? Might be better to just document that the BOUT-configs repo exists?

I'm not sure, but if someone needs to edit some config file for their machine, wouldn't that make the BOUT-dev repo 'dirty' (in the sense of git describe)? I think it's nicer to be able to run with the repo being 'clean' as much as possible for provenance tracking purposes - actually it would be nice to record to the output/log files whether it was 'dirty' or not (and possibly even record the git diff - I think we discussed on Slack a while ago when I was doing similar things for STORM).

@ZedThree
Copy link
Member Author

Very good points @johnomotani -- I agree, having the configs remain separate is probably the best thing to do.

@bendudson Any thoughts on this?

If we're happy keeping them separate, I'll remove the submodule from this PR.

@bendudson
Copy link
Contributor

Thanks @ZedThree and @johnomotani yes I think this is a good plan. If anything I think the BOUT-dev repo could be a submodule of the configs repository: The configs are for a particular version of BOUT++.
We briefly discussed today having multiple config repositories e.g. NERSC, Livermore,... For now perhaps directories:

BOUT-config

  • Cori/
    cori-config.sh
    ...
    BOUT-dev <- Submodule, pointing to known good commit?
  • Perlmutter/
  • Lassen/
  • Archer/
  • Marconi/

@ZedThree
Copy link
Member Author

Bundling BOUT-dev in the configs repo is a good idea. That sort of layout especially makes sense if we want to go even further and make a "superproject" where we bundled everything together, something like:

|- BOUT-dev
|- configs
| |- archer
| |- cori
| ...
\- externalpackages
  |- netCDF
  |- HYPRE
  |- SUNDIALS
  |- PETSc
  ...

@bendudson bendudson merged commit 4fca11d into next-hypre-outerloop-cuda-merged Dec 1, 2021
@bendudson bendudson deleted the gpu-config-submodule branch December 1, 2021 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants