Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation on curvilinear differentiation #2477

Merged
merged 6 commits into from
Dec 8, 2021
Merged

Conversation

dschwoerer
Copy link
Contributor

No description provided.

dschwoerer and others added 5 commits December 8, 2021 16:50
The formula is only valid in ortogonal systems.
In general the cosine of the angle needs to be included, so drop this to
avoid confusion.
* Add more introduction
* Explain more symbols
* Correct author's name
ZedThree
ZedThree previously approved these changes Dec 8, 2021
Copy link
Member

@ZedThree ZedThree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one pedantic fix :)

manual/sphinx/user_docs/coordinates.rst Outdated Show resolved Hide resolved
@ZedThree
Copy link
Member

ZedThree commented Dec 8, 2021

Actually, could you also rebase this to master? I want to get 4.4.1 out next week, and then we can merge it into next anyway

Co-authored-by: Peter Hill <zed.three@gmail.com>
@bendudson bendudson merged commit b463876 into next Dec 8, 2021
@bendudson bendudson deleted the coords-doc branch December 8, 2021 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants