Fix bug in PetscLib that broke no-PETSc builds #2492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The no-PETSc branch needs to forward-declare `SNES` to avoid error.
|
clang-tidy review says "All clean, LGTM! 👍" |
ZedThree
approved these changes
Jan 28, 2022
|
Thanks @johnomotani and @bshanahan ! We should probably remove the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The no-PETSc branch needs to forward-declare
SNESto avoid error.Thanks to @bshanahan for finding the bug.
Are we missing a job with no PETSc in the CI testing? I'd have thought that this should have been caught automatically... If anyone wants to add on to this PR to tweak the CI, I'm not planning to, so feel free!