Update outer boundaries in PETSc 3D solver #2496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
clang-tidy review says "All clean, LGTM! 👍" |
Only affects boundary conditions if MXG > 1: First set of boundary cells are already set as part of the solve. Changes from always zero-gradient to extrapolating. If zero-gradient boundary conditions are set then the result will not change.
johnomotani
requested changes
Feb 16, 2022
There was a problem hiding this comment.
Thanks @bendudson! This looks totally general, and consistent with boundary_standard.cxx (with suggestions below). Nice how simple it is!
|
Is this one of things that can only be effectively tested with MMS? |
Probably. It's tricky because the extra boundary cells affected by this PR are outside the stencil of the forward operator, so aren't checked by the existing integrated tests. |
Co-authored-by: johnomotani <john.omotani@ukaea.uk>
Co-authored-by: johnomotani <john.omotani@ukaea.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only affects boundary conditions if MXG > 1: First set of boundary cells are already set as part of the solve.
Changes from always zero-gradient to extrapolating. If zero-gradient boundary conditions are set then the result will not change.