Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NLS detection #2509

Merged
merged 1 commit into from
Mar 1, 2022
Merged

Fix NLS detection #2509

merged 1 commit into from
Mar 1, 2022

Conversation

dschwoerer
Copy link
Contributor

  • If NLS is now requested, it fails if not found
  • It is only added as a dependency, if found
  • Default is to only use if present

Resolves: #2508

ZedThree
ZedThree previously approved these changes Feb 25, 2022
Copy link
Member

@ZedThree ZedThree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @dschwoerer !

Some suggestions to look at

CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
* If NLS is now requested, it fails if not found
* It is only added as a dependency, if found
* Default is to only use if present
@ZedThree ZedThree merged commit 62c65a2 into next Mar 1, 2022
@ZedThree ZedThree deleted the gettext branch March 1, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants