Switch to CMake in CI and docs #2514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschwoerer
force-pushed
the
ci-cmake-only
branch
from
8d8aaed
to
dbbda5e
Compare
dschwoerer
force-pushed
the
ci-cmake-only
branch
from
dbbda5e
to
6628bb5
Compare
|
Is it intentionally that we now require |
|
I think |
|
If you get fastcov to work in CI ... |
dschwoerer
force-pushed
the
ci-cmake-only
branch
from
5ac6b19
to
995151d
Compare
We need to link with gcov to get gcda files. Further, they are in the build directories, not the source directories.
Co-authored-by: Peter Hill <peter.hill@york.ac.uk>
|
Todo before merge:
|
* next: (517 commits) Apply clang-format Fix some clang-tidy suggestions in PCR Thomas Remove duplicated header in Laplace PCR Thomas Fix type of `Coordinates::zlength/dz` in Laplace PCR Thomas Fix `LaplacePCR_THOMAS` constructor for new Laplace parameters Docs: Fix some formatting issues Docs: Fix some broken tables Docs: Fix some xBout links Docs: Remove outdated note Docs: Fix some whitespace Docs: Update Ubuntu instructions Docs: Explain some common CMake options Docs: Add a short quickstart guide with basic instructions Docs: Move and expand section on building examples/models with CMake Docs: Whitespace cleanup Docs: Expand basic CMake docs Docs: Note that configure is deprecated Docs: Remove out-dated note Docs: Use `https` instead of `git` protocol Remove some useless forward declarations ...
|
I updated the docs, however, I haven't tested all commands - so checking would be greatly appreciated. |
… of 'Advanced installation options' page of manual.
…ions' page of manual.
…>' in 'Compiling BOUT++' section of 'Advanced installation options' page of manual.
on 'Advanced installation options' page of manual. (version 3.19 is not compatible) [skip ci]
Include -S and -B flags, so examples are more consistent. Use <build-directory> to indicate the path to the build directory. [skip ci]
on 'Advanced installation options' page of manual. [skip ci]
Review of PR #2514 (Switch to CMake)
ZedThree
approved these changes
Jun 14, 2023
|
The failing tests are just Fedora, and that was already fixed in next |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of #2502
Now without removing configure files - to be done for v5.1.0