Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use localmesh not m in LaplaceXZ constructor #2528

Merged
merged 1 commit into from
Apr 27, 2022
Merged

Use localmesh not m in LaplaceXZ constructor #2528

merged 1 commit into from
Apr 27, 2022

Conversation

bendudson
Copy link
Contributor

The base class constructor handles the case where no mesh is given, by setting localmesh to bout::globals::mesh. The pointer m in the LaplaceXZcyclic constructor may still be null.

@bendudson
Use localmesh not m in LaplaceXZ constructor
25db17e 
The base class constructor handles the case where no mesh is given,
by setting `localmesh` to `bout::globals::mesh`. The pointer `m` in
the `LaplaceXZcyclic` constructor may still be null.
@bendudson bendudson added bugfix small-change Changes less than 100 lines - should be quick to review labels Mar 15, 2022
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@ZedThree ZedThree merged commit b1b7326 into next Apr 27, 2022
@ZedThree ZedThree deleted the next-bugfix-laplacexz-cyclic branch April 27, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschwoerer dschwoerer dschwoerer approved these changes

Assignees
No one assigned
Labels
bugfix small-change Changes less than 100 lines - should be quick to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bendudson @dschwoerer @ZedThree