Rename FV::Div_a_Grad_perp to FV::Div_a_Grad_perp #2536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This operator is calculating the Divergence of the Gradient (i.e. Laplace), not the Divergence of the Laplacian.
dschwoerer
added
bugfix
backport candidiate
bendudson
previously approved these changes
Apr 25, 2022
dschwoerer
force-pushed
the
laplace-naming
branch
from
438a269
to
1273a26
Compare
ZedThree
requested changes
Apr 26, 2022
Co-authored-by: Peter Hill <peter.hill@york.ac.uk>
ZedThree
approved these changes
Apr 26, 2022
|
Failing test is clang-tidy-review which is fixed in both master/next |
ZedThree
changed the title
|
Does the title contain |
|
Oops, sorry, I clearly didn't read things properly! I'll just have to remember to fix it for the changelog |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This operator is calculating the Divergence of the Gradient (i.e.
Laplace), not the Divergence of the Laplacian.
Should this be called
Div_perp_a_Grad_perpor evenDiv_perp_K_Grad_perp(similar to the parallel version)?