Print whether an option was marked as conditionally used #2542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should help porting bigger input files / codes to the error on unused option.
ZedThree
previously approved these changes
Apr 29, 2022
|
Tests are failing because the output has now changed. We either need to update the tests, or perhaps only add this to the output if a |
Adds a comment "unused value (NOT marked conditionally used)" or "unused value (marked conditionally used)" depending on whether the option was marked conditionally used
Will now record in the output file if options were unused, and if so if they were conditionally unused.
* next: (447 commits) Use MPI_COMM_NULL rather than nullptr Apply clang-format changes Apply clang-format changes Don't compile LaplaceXY2 with 3D metrics Apply clang-format changes Apply clang-format changes Laplacexy2 modifications Apply clang-format changes Apply clang-format changes nvcc needs toString(HYPRE_SOLVER_TYPE) nvcc now seems to need the factory flags Update fmt to latest version Apply clang-format changes Output BoutException.what() in PhysicsModel main() use hasParallelSlices Apply clang-format changes Only destroy if it exists Backgrounds don't work with parallel BCs Ensure that parallel slices exist Prefer non-const return value ...
ZedThree
changed the title
|
I reset to remove the auto-clang-format commit, then merged next, then re-applied clang-format, which removed all the conflicts, but did require a force push. |
ZedThree
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should help porting bigger input files / codes to the error on unused
option.