Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in comments explaining algorithm of LaplaceNaulin #2545

Merged
merged 2 commits into from
Jul 26, 2022

Conversation

johnomotani
Copy link
Contributor

No description provided.

@johnomotani johnomotani added the small-change Changes less than 100 lines - should be quick to review label May 6, 2022
@johnomotani
Copy link
Contributor Author

Is there a way to skip the automatic clang-format changes? It's true some of the comment lines in naulin_laplace.cxx are 'too long', but they look better like that than in the reformatted version.

@ZedThree
Copy link
Member

ZedThree commented May 6, 2022

Yep, you can use // clang-format off/// clang-format on: https://clang.llvm.org/docs/ClangFormatStyleOptions.html#disabling-formatting-on-a-piece-of-code

@johnomotani johnomotani marked this pull request as draft May 6, 2022 12:39
bendudson
bendudson previously approved these changes Jul 20, 2022
@ZedThree
Copy link
Member

@johnomotani Is this just marked draft due to clang-format changing the comments? If so, I'll fix it so we can merge this

@johnomotani
Copy link
Contributor Author

@ZedThree

Is this just marked draft due to clang-format changing the comments? If so, I'll fix it so we can merge this

I think so!

@ZedThree ZedThree marked this pull request as ready for review July 26, 2022 13:39
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@ZedThree ZedThree merged commit ab69d52 into master Jul 26, 2022
@ZedThree ZedThree deleted the fix-typo-LaplaceNaulin branch July 26, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small-change Changes less than 100 lines - should be quick to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants