-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tool to move headers under include/bout
and fix #include
s
#2568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces similar bash tool
dschwoerer
reviewed
Sep 22, 2022
38 tasks
Trouble running |
bendudson
reviewed
Feb 2, 2023
Changes `#include` lines to point to headers under `bout/`
Turns out there's a few other files that need the paths updating. Fix incoming. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces similar bash tool, but tries to preserve history by first moving headers into a single commit, then adding compatibility shim headers (that issue a
#warning
and#include
the new location) in a second commit. Also when updating#include
s, it prints a diff of the changes, to allow the user to review before applying (just in case something goes wrong!).Should be essentially last PR into 5.0 to avoid massive conflicts.
To apply, run in two steps:
./bin/bout-v5-header-upgrader.py --files $(find . -type f -name "*.[hc]xx")
to make sure all the#include
s point to the new location./bin/bout-v5-header-upgrader.py --move-deprecated-headers
to do the actual movingThe first command can then be used to fix user code and models. The second command should only need to be run once, ever.