SNB and InvertParDiv for nonuniform grids #2572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solves `A + Div_par( B Grad_par )` in divergence form. Adapted from `InvertPar` which uses `Grad2_par2 = Grad_par(Grad_par)` in non-conservative form.
Enables the fluxes at the boundaries to be fixes to be the same as the Spitzer-Harm calculation.
The integral of Div(Q) over the domain should be the same for SNB and S-H methods, because the Neumann boundary conditions on H should ensure this.
Runs in open domain with boundaries, checking that the boundary fluxes are the same for SH and SNB calculations even with non-uniform mesh.
Strangely, changing calculation of dy, J from float to double makes difference between SNB and SH heat fluxes larger.
Forgot to add, so wouldn't be compiled in Autotools build
ZedThree
reviewed
Aug 31, 2022
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
ZedThree
previously approved these changes
Aug 31, 2022
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| if (closed) { | ||
| // Twist-shift | ||
| int rank; |
There was a problem hiding this comment.
warning: variable 'rank' is not initialized [cppcoreguidelines-init-variables]
Suggested change
| int rank; | |
| int rank = 0; |
| if (closed) { | ||
| // Twist-shift | ||
| int rank; | ||
| int np; |
There was a problem hiding this comment.
warning: variable 'np' is not initialized [cppcoreguidelines-init-variables]
Suggested change
| int np; | |
| int np = 0; |
|
Tested on SD1D in 1D: The behaviour disappears when using a uniform grid. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SNB solver was giving incorrect fluxes on non-uniform grids because the
InvertParsolver doesn't handle these consistently.InvertParDerivclass that solves equations of the formA + Div_par(B Grad_par)similar toInvertParwhich solvesA + B Grad2_par2 + ....InvertParDiv