-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better versioning for BOUT++ #2595
Conversation
Thanks @d7919 |
Thanks @dschwoerer, I finally found some time to have a play with this! This still needs manual bumping of the versions inside the EDIT: Could we pull out the Making it fall back to the hardcoded version if the One could imagine calling out to another tool to work out the version. In fact, But that can wait for a future PR, this works well for now. |
I actually tried So, yes, unfortunately, it needs manual bumping. I think setting BOUT_PREVIOUS_VERSION and BOUT_NEXT_VERSION might be nicer 👍 |
We will need |
Ah, good point. That is a bit of a shame. Also very true that we just decide what the next version will be, and don't really use an algorithm. Nevermind, this is still nice! |
I've changed the hardcoded versions to variables, and updated the release checklist to reflect this. I did consider making the variables settable from the command line (by making them cache variables), which would make it easier to test and change the variables for maintainers, but would probably cause more problems than it would solve when the version doesn't update automatically. |
This can go in as soon as the tests complete |
Inspired by
setuptools_scm