Insert Options attributes with initializer_list #2598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is probably more readable if setting multiple attributes:
```
Options options;
options["value"].insertAttributes({
{"units", "m/s"},
{"conversion", 10.2},
{"long_name", "important value"}
});
```
Uses `std::map::emplace` internally, so doesn't replace or update
values.
Includes tests and some documentation.
bendudson
added
feature
small-change
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ZedThree
previously approved these changes
Oct 13, 2022
There was a problem hiding this comment.
LGTM! I wonder if we should go even further and have something like:
namespace bout {
struct Metadata {
std::string units;
std::string conversion;
std::string long_name;
}
}Maybe that actually adds too much complication for not enough benefit.
Uses
std::map::emplaceinternally, so doesn't replace or update values.
It would be good to note this in the docstring and the manual, might be surprising otherwise!
Change the semantics so that attributes are always set, rather than not replacing already set attributes. This way is probably more intuitive.
…-dev into next-options-attributes
|
Thanks @ZedThree ! The semantics of |
|
clang-tidy review says "All clean, LGTM! 👍" |
Forgot to update the test, now that attributes are replaced.
|
clang-tidy review says "All clean, LGTM! 👍" |
ZedThree
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is probably more readable if setting multiple attributes:
Usesstd::map::emplaceinternally, so doesn't replace or update values.Replaces any values that were previously set.
Includes tests and some documentation.