Fix SAVE_ONCE for Vector2/3D
#2633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing `DataFileFacade::add(Vector2/3D)` overloads, along with a test
|
clang-tidy review says "All clean, LGTM! 👍" |
dschwoerer
previously approved these changes
Jan 24, 2023
| # Test file I/O by loading from restart files and writing to dump files | ||
| # | ||
| # requires: netcdf | ||
| # cores: 4 |
There was a problem hiding this comment.
Suggested change
| # cores: 4 | |
| # cores: 2 |
There was a problem hiding this comment.
Oh yes, and probably should fix that comment above too
- Comment updated to refer to DataFileFacade - Message printed on success now has correct test name - Changed number of cores from 4 to 2
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing
DataFileFacade::add(Vector2/3D)overloads, along with a testFixes #2632
I couldn't see a decent existing place to add a test, so I added a whole new one