Track more build options #2634
Merged
Track more build options #2634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschwoerer
commented
Jan 24, 2023
|
clang-tidy review says "All clean, LGTM! 👍" |
ZedThree
reviewed
Jan 24, 2023
src/bout++.cxx
Outdated
| options["has_fftw"] = bout::build::has_fftw; | ||
| options["has_gettext"] = bout::build::has_gettext; | ||
| options["has_lapack"] = bout::build::has_lapack; | ||
| options["has_netcdf"] = bout::build::has_netcdf; | ||
| options["has_petsc"] = bout::build::has_petsc; | ||
| options["has_legacy_netcdf"] = bout::build::has_legacy_netcdf; |
There was a problem hiding this comment.
Oh, this build flag should probably be removed entirely? It's not actually used for anything
There was a problem hiding this comment.
Currently referenced here:
CMakeLists.txt:set(BOUT_HAS_LEGACY_NETCDF OFF)
autoconf_build_defines.hxx.in:#undef BOUT_HAS_LEGACY_NETCDF
bin/bout-config.in:has_legacy_netcdf="@BOUT_HAS_LEGACY_NETCDF@"
bin/bout-config.in: echo " --has-legacy-netcdf -> $has_legacy_netcdf"
bin/bout-config.in: echo $has_legacy_netcdf
bin/bout-v5-macro-upgrader.py: "new": "BOUT_HAS_LEGACY_NETCDF",
cmake_build_defines.hxx.in:#define BOUT_HAS_LEGACY_NETCDF 0
configure: (skipped)
configure.ac:BOUT_HAS_LEGACY_NETCDF=no
configure.ac: BOUT_HAS_LEGACY_NETCDF=yes
configure.ac: BOUT_HAS_LEGACY_NETCDF=yes
configure.ac:BOUT_DEFINE_SUBST(BOUT_HAS_LEGACY_NETCDF, [NETCDF support])
configure.ac:AC_MSG_NOTICE([ NetCDF support : $BOUT_HAS_NETCDF (legacy: $BOUT_HAS_LEGACY_NETCDF)])
include/bout/build_config.hxx:constexpr auto has_legacy_netcdf = static_cast<bool>(BOUT_HAS_LEGACY_NETCDF);
include/options_netcdf.hxx:#if !BOUT_HAS_NETCDF || BOUT_HAS_LEGACY_NETCDF
src/bout++.cxx: has_netcdf ? (has_legacy_netcdf ? " (Legacy)" : " (NetCDF4)") : "";
src/bout++.cxx: options["has_legacy_netcdf"] = bout::build::has_legacy_netcdf;
src/sys/options/options_netcdf.cxx:#if BOUT_HAS_NETCDF && !BOUT_HAS_LEGACY_NETCDF
tests/integrated/test-options-netcdf/CMakeLists.txt: CONFLICTS BOUT_HAS_LEGACY_NETCDF
tests/integrated/test-squash/runtest: "(wtime|ncalls|arkode|cvode|run_id|run_restart_from|M.?SUB|N.?PE|iteration|wall_time|has_legacy_netcdf).*"
tests/unit/sys/test_options_netcdf.cxx:#if BOUT_HAS_NETCDF && !BOUT_HAS_LEGACY_NETCDF
tools/pylib/boutconfig/__init__.py.cin: "has_legacy_netcdf": "@BOUT_HAS_LEGACY_NETCDF@",
tools/pylib/boutconfig/__init__.py.in: "has_legacy_netcdf": "@BOUT_HAS_LEGACY_NETCDF@",
configure might set this to YES - so should we wait till configure is dropped?
Or is it already safe to do so?
There was a problem hiding this comment.
We'll drop configure soon, but this flag is already deprecated, so no need to add it here
dschwoerer
force-pushed
the
build-opts
branch
from
90369ab
to
9ce221e
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ZedThree
requested changes
Feb 22, 2023
Avoids an error being thrown on restart if these flags have already been set.
ZedThree
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xbout relies on
use_metric_3dbeing present ...