-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix use of removed Datafile
in Laplacian
constructor; update docs
#2636
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
@@ -47,8 +47,7 @@ | |||
|
|||
#include <bout/scorepwrapper.hxx> | |||
|
|||
LaplaceIPT::LaplaceIPT(Options* opt, CELL_LOC loc, Mesh* mesh_in, Solver* UNUSED(solver), | |||
Datafile* UNUSED(dump)) | |||
LaplaceIPT::LaplaceIPT(Options* opt, CELL_LOC loc, Mesh* mesh_in, Solver* UNUSED(solver)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: constructor does not initialize these fields: jy, proc_in, proc_out, myproc, nproc, xs, xe [cppcoreguidelines-pro-type-member-init]
src/invert/laplace/impls/iterative_parallel_tri/iterative_parallel_tri.hxx:179:
- int jy;
+ int jy{};
src/invert/laplace/impls/iterative_parallel_tri/iterative_parallel_tri.hxx:220:
- int proc_in, proc_out;
+ int proc_in{}, proc_out{};
src/invert/laplace/impls/iterative_parallel_tri/iterative_parallel_tri.hxx:223:
- int myproc;
+ int myproc{};
src/invert/laplace/impls/iterative_parallel_tri/iterative_parallel_tri.hxx:226:
- int nproc;
+ int nproc{};
src/invert/laplace/impls/iterative_parallel_tri/iterative_parallel_tri.hxx:235:
- int xs, xe;
+ int xs{}, xe{};
@@ -61,8 +61,7 @@ | |||
|
|||
using namespace std; | |||
|
|||
LaplacePCR::LaplacePCR(Options* opt, CELL_LOC loc, Mesh* mesh_in, Solver* UNUSED(solver), | |||
Datafile* UNUSED(dump)) | |||
LaplacePCR::LaplacePCR(Options* opt, CELL_LOC loc, Mesh* mesh_in, Solver* UNUSED(solver)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: constructor does not initialize these fields: inbndry, outbndry [cppcoreguidelines-pro-type-member-init]
src/invert/laplace/impls/pcr/pcr.hxx:121:
- int inbndry;
+ int inbndry{};
src/invert/laplace/impls/pcr/pcr.hxx:123:
- int outbndry;
+ int outbndry{};
Here's how the new docs theme looks Any major objections to the new theme? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ZedThree !
There was still a use of
Datafile
in theLaplacian
constructor which one of the examples (hw-3D
) was using, which meant it didn't compile.I (finally!) added some docs on the new file IO system that relies on
OptionsNetCDF
, and how to update physics models to use it.Also fix the predefined macros for doxygen so it preprocesses everything correctly.
Lastly, just for fun, I've updated the docs to use sphinx-book-theme as a refresh for v5. It's cleaner and easier to navigate than the default readthedocs theme.
This is (hopefully) truly the last PR for v5 -- everything else is getting bumped to 5.1, unless there are new build-blocking bugs discovered in the next week.