switch to BOUT_FOR and simplify Div_a_Grad_perp #2641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ZedThree
requested changes
Feb 22, 2023
Using a template allows to retain Field2D in the case of 2D metrics.
ZedThree
reviewed
Feb 23, 2023
|
clang-tidy review says "All clean, LGTM! 👍" |
ZedThree
reviewed
Feb 23, 2023
Comment on lines
+17
to
+20
| template <class T> | ||
| Slices<T> makeslices(bool use_slices, const T& field) { | ||
| return Slices<T>(use_slices, field); | ||
| } |
There was a problem hiding this comment.
Just to note that we'll upgrade to C++17 soon and that should be able to deduce T without this helper
ZedThree
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.