Improve invSg calculation #2646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It would be better to also do the calculation for the parallel slices ...
It doesn't change and avoids an unneeded communication. Can give significan speedup.
|
Requires #2640 |
|
clang-tidy review says "All clean, LGTM! 👍" |
ZedThree
reviewed
Feb 23, 2023
ZedThree
reviewed
Apr 20, 2023
|
clang-tidy review says "All clean, LGTM! 👍" |
|
Thanks @ZedThree for your valuable feedback and suggestions 👍 I think I have addressed everything. |
ZedThree
reviewed
Apr 26, 2023
| @@ -149,7 +149,7 @@ public: | |||
|
|
|||
| FieldMetric DDY(const Field2D& f, CELL_LOC outloc = CELL_DEFAULT, | |||
| const std::string& method = "DEFAULT", | |||
| const std::string& region = "RGN_NOBNDRY"); | |||
| const std::string& region = "RGN_NOBNDRY") const; | |||
There was a problem hiding this comment.
Thanks! Bit by bit, we'll be const correct eventually
ZedThree
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do some caching and fixes for FCI