Improve checking in coords constructor #2650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschwoerer
added
the
small-change
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ZedThree
requested changes
Feb 22, 2023
There was a problem hiding this comment.
Thanks @dschwoerer, I'm always in favour of obvious helper functions like this! Just some small changes to make clang-tidy happy
|
Thanks! I was wondering whether clang-tidy would post a corrected version of the suggestion (and then forgot) 👍 |
dschwoerer
force-pushed
the
coords-checking
branch
from
8ae96d3
to
0479c32
Compare
|
734 conflicts, over 10k changed lines, over 200 files changed - that used to be a small change. Thanks clang-tidy! I have rebased (removing clang-tidy commits) and force pushed - maybe it works now ... |
Co-authored-by: Peter Hill <peter.hill@york.ac.uk>
dschwoerer
force-pushed
the
coords-checking
branch
from
bb672bb
to
71f1169
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
ZedThree
requested changes
Mar 23, 2023
|
clang-tidy review says "All clean, LGTM! 👍" |
ZedThree
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.