Update bundled boututils and boutdata #2657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So the difference between old and new boututils/boutdata is this changed to this: The question is, should this be reverted in the python packages? Should we stop supporting evolving fperp? |
boututils changed the default for datafile to netcdf4, which breaks reading the y position of the FieldPerp slices.
|
Is the issue that boutdata is now writing |
This reverts commit 73f5d4d.
Revert "Workaround for test-restart-io for recent boututils"
Update boututils and boutdata to working versions
ZedThree
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that may be the reason builds for fedora are failing, as there not the bundled copies are used and one test failure seems to be related to that ...