Fix some warnings #2661
Merged
Fix some warnings #2661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
clang-tidy review says "All clean, LGTM! 馃憤" |
|
clang-tidy review says "All clean, LGTM! 馃憤" |
ZedThree
previously approved these changes
Feb 22, 2023
ZedThree
changed the title
|
Thanks @dschwoerer, didn't realise you'd fixed the output warning already! That's a sensible solution to the PVODE warnings too, thanks! |
|
clang-tidy review says "All clean, LGTM! 馃憤" |
ZedThree
reviewed
Feb 22, 2023
dschwoerer
commented
Feb 22, 2023
MPI_DOUBLE is a macro, so this check can break, even if there is no mismatch.
|
clang-tidy review says "All clean, LGTM! 馃憤" |
ZedThree
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2653 unfortunately replaced one warning with a different warning 馃檲