Some fixes for tokamak-2fluid example #2668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not comprehensive, still fails to run successfully on basic input file (zero pivot in cyclic reduce) Fixes: - unused variables - wrong variable names (including case) - creating laplacians from wrong input sections - some issues with staggering
|
clang-tidy review says "All clean, LGTM! 👍" |
dschwoerer
reviewed
Feb 22, 2023
| // Equation terms | ||
|
|
||
| auto& ni_options = globalOptions["Ni"]; | ||
| ni_options.setConditionallyUsed(); |
There was a problem hiding this comment.
Wouldn't it be nicer to only set that if the option is not used?
|
Merging for now as better than nothing. I think the correct thing to do is to remove examples that don't work or are not useful for e.g. the manual. If people want full physics models then those are in other repositories. |
|
Hello, I have recently installed bout and have been trying the examples. This is the error I get for the tokamak-2fluid example. Was this fixed since the issue was brought up? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not comprehensive, still fails to run successfully on basic input file (zero pivot in cyclic reduce)
Fixes:
Currently fails with:
The
d3dcases are missingShiftAnglefrom the grid file and so don't run for that reason.Maybe we should have a clean out of the examples, and delete everything that doesn't successfully run?