Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: If we are on a tag, we should use that as version #2683

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Python: If we are on a tag, we should use that as version #2683

merged 1 commit into from
Mar 22, 2023

Conversation

dschwoerer
Copy link
Contributor

No description provided.

ZedThree
ZedThree approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@ZedThree ZedThree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit worried this getting complex -- should we just require setuptools_scm and use that?

@ZedThree ZedThree changed the title If we are on a tag, we should use that as version Python: If we are on a tag, we should use that as version Mar 22, 2023
@ZedThree ZedThree merged commit 6ababba into master Mar 22, 2023
@ZedThree ZedThree deleted the use-tag-version branch March 22, 2023 17:50
@dschwoerer
Copy link
Contributor Author

setuptools_scm cannot bump anything but the patch level - so we cannot say this is going to be v5.1.0 or v6.0.0 ...

@dschwoerer dschwoerer mentioned this pull request Mar 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZedThree ZedThree ZedThree approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dschwoerer @ZedThree